This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Warn user against using torch tensors as arguments of random variables #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39169577 |
AishwaryaSivaraman
added a commit
to AishwaryaSivaraman/beanmachine
that referenced
this pull request
Aug 31, 2022
facebookresearch#1639) Summary: Pull Request resolved: facebookresearch#1639 Bean Machine uses the hash value of the arguments of random variables to identify them, which means that foo(1) and foo(tensor(1)) are considered two different random variables. Further in PyTorch, tensors are hashed by memory address instead of by value, so we can have hash(tensor(1)) != hash(tensor(1)). Therefore, it’s not recommended to use tensors as indices of random variables. In this change, 1. In `rv_identifier.py` we identify if tensors are used as arguments to RVs and warn the user against its use. 2. Added a test case to `rv_identifier_test.py` to check if the warning is triggered correctly when the user provides a tensor instead of a primitive argument. Differential Revision: D39169577 fbshipit-source-id: 487719d5fd66de2936e7e1f6d8885f6edb5498ac
|
This pull request was exported from Phabricator. Differential Revision: D39169577 |
AishwaryaSivaraman
force-pushed
the
export-D39169577
branch
from
8ec6c68
to
13afc25
Compare
facebookresearch#1639) Summary: Pull Request resolved: facebookresearch#1639 Bean Machine uses the hash value of the arguments of random variables to identify them, which means that foo(1) and foo(tensor(1)) are considered two different random variables. Further in PyTorch, tensors are hashed by memory address instead of by value, so we can have hash(tensor(1)) != hash(tensor(1)). Therefore, it’s not recommended to use tensors as indices of random variables. In this change, 1. In `rv_identifier.py` we identify if tensors are used as arguments to RVs and warn the user against its use. 2. Added a test case to `rv_identifier_test.py` to check if the warning is triggered correctly when the user provides a tensor instead of a primitive argument. Differential Revision: D39169577 fbshipit-source-id: 927af335f605cfc12fae6f3a6ca7784122579559
|
This pull request was exported from Phabricator. Differential Revision: D39169577 |
AishwaryaSivaraman
force-pushed
the
export-D39169577
branch
from
13afc25
to
7fab2a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bean Machine uses the hash value of the arguments of random variables to identify them, which means that foo(1) and foo(tensor(1)) are considered two different random variables. Further in PyTorch, tensors are hashed by memory address instead of by value, so we can have hash(tensor(1)) != hash(tensor(1)). Therefore, it’s not recommended to use tensors as indices of random variables.
In this change,
rv_identifier.pywe identify if tensors are used as arguments to RVs and warn the user against its use.rv_identifier_test.pyto check if the warning is triggered correctly when the user provides a tensor instead of a primitive argument.Differential Revision: D39169577