This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Add constraint comparison utility to world.utils.
#542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D25935106 |
neerajprad
force-pushed
the
export-D25935106
branch
from
2f67696
to
bba916b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25935106 |
Summary: Pull Request resolved: facebookresearch/beanmachine#542 This adds an equality testing utility for `torch.constraint` objects/classes, so that these comparisons can be consolidated within a single utility function `is_constraint_eq`. Usage: ``` is_constraint_eq(dist.support, (constraints.real, constraints.greater_than)) ``` , instead of: ``` isinstance(dist.support, (constraints._Real, constraints._GreaterThan)) ``` , or the more obfuscatory ``` dist.support is constraints.real or isinstance(dist.support, constraints.greater_than) ``` See pytorch/pytorch#50616 for more details (note that the changes suggested in the issue are complementary). - This avoids usage of the non-public constraint classes (like `constraints._Real`, `constraints._Interval`). - Makes it possible to consolidate future changes (e.g. those arising out of the introduction of an `Independent` constraint - pytorch/pytorch#50547) within a single function. This is a pre-requisite to some other fixes that are currently blocking D25918330. I will add these small fixes when I merge D25918330. Differential Revision: D25935106 fbshipit-source-id: f585562b0f627f9b9669a54bcb2b45b05d560fe9
neerajprad
force-pushed
the
export-D25935106
branch
from
bba916b
to
89fde5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25935106 |
|
This pull request has been merged in 414dd99. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds an
isinstancelike check fortorch.constraintobjects/classes, so that these comparisons can be consolidated within a single utility functionis_constraint_eq.Usage:
, instead of:
, or the more obfuscatory
See pytorch/pytorch#50616 for more details (note that the changes suggested in the issue are complementary).
constraints._Real,constraints._Interval).Independentconstraint - Independent constraint pytorch/pytorch#50547) within a single function.This is a pre-requisite to some other fixes that are currently blocking D25918330. I will add these small fixes when I merge D25918330.
Differential Revision: D25935106