Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch predictor #2888

Closed
wants to merge 4 commits into from
Closed

Add batch predictor #2888

wants to merge 4 commits into from

Conversation

sailist
Copy link

@sailist sailist commented Apr 8, 2021

It's not very convenient when do batch inference by using original detectron2 api, the solution provided here #282 (comment) is good, and I extended it's code to support more forms.

Add Predictor for batch data
format by linter
@facebook-github-bot
Copy link
Contributor

Hi @sailist!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

B011 Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError()
@ashnair1
Copy link
Contributor

@sailist Have you tried using this BatchPredictor with AsyncPredictor?

@sailist
Copy link
Author

sailist commented May 12, 2021

Fine, I'll try it, thanks.

@Sorakuhaku
Copy link

Can you add unit test to ensure it is working properly?

@ppwwyyxx
Copy link
Contributor

As the doc of DefaultPredictor mentions, it is only for simple demo purposes and we do not plan to extend it with new capabilities. Users are expected to use the model object following its formats (which supports batch predictions) if more complicated logic is needed.

@ppwwyyxx ppwwyyxx closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants