Make detectron2 usable without building C extensions #3909
Closed
+117
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@zhanghang1989 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ppwwyyxx has updated the pull request. You must reimport the pull request before landing. |
|
@zhanghang1989 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C code in detectron2 are:
So all the core features should be able to work without building any C code.
This PR make D2 usable without compiling C extensions by making some import statements optional. This will make it easier to use D2 where the compilation toolchain & build system is different.
(There is an open internal task about this as well)