Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/token annotator whitespace and reset #892

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix/token annotator whitespace and reset #892

merged 2 commits into from
Feb 24, 2022

Conversation

maxbartolo
Copy link
Contributor

Requires testing by @ktirumalafb first

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2022
This was linked to issues Feb 23, 2022
QA CreateInterface: Whitespace around punctuation #872
Closed
QA (not urgent): Clicking on an answer no longer removes that answer #886
Closed
ktirumalafb
ktirumalafb approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@ktirumalafb ktirumalafb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, and it works great! Clicking on a selected answer does de-select it. LGTM!

@ktirumalafb ktirumalafb merged commit ab17e4a into main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktirumalafb ktirumalafb ktirumalafb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
3 participants
@maxbartolo @ktirumalafb @facebook-github-bot