Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS] More flexible parameter handling in the low tensor case #409

Closed
blefaudeux opened this issue Feb 22, 2021 · 1 comment · Fixed by #460
Closed

[OSS] More flexible parameter handling in the low tensor case #409

blefaudeux opened this issue Feb 22, 2021 · 1 comment · Fixed by #460
Assignees
Labels
enhancement New feature or request

Comments

@blefaudeux
Copy link
Contributor

🚀 Feature

Have a better fallback than asserting when there are not enough tensors to shard

Motivation

#406 rightfully asserts for now when there are not enough tensors to shard, but in truth we could have a more graceful fallback in that case, not all ranks will contribute to the optim update but that's typically fine and not really a perf limitation

Pitch

When not enough tensors, just make some ranks data-parallel contributors and skip the sharding for them.

Alternatives

Current state which imposes a hard limitation on ranks/number of tensors in the model

Additional context

cc @kamo-naoyuki

@blefaudeux blefaudeux self-assigned this Feb 22, 2021
@blefaudeux blefaudeux added the enhancement New feature or request label Feb 22, 2021
@blefaudeux
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant