Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][FSDP] Don't remove post backward hooks for multiple backward fix #1079

Merged
merged 8 commits into from
Sep 24, 2022
Merged

[Fix][FSDP] Don't remove post backward hooks for multiple backward fix #1079

merged 8 commits into from
Sep 24, 2022

Conversation

min-xu-ai
Copy link
Contributor

@min-xu-ai min-xu-ai commented Sep 23, 2022 •
edited

What does this PR do?

Fixes #918

This takes over the PR #923

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 馃檭
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2022
@min-xu-ai min-xu-ai changed the title wip [Fix][FSDP] Don't remove post backward hooks for multiple backward fix Sep 24, 2022
@min-xu-ai min-xu-ai marked this pull request as ready for review September 24, 2022 15:27
@min-xu-ai min-xu-ai mentioned this pull request Sep 24, 2022
Closed
@min-xu-ai min-xu-ai merged commit f4fcee7 into facebookresearch:main Sep 24, 2022
@min-xu-ai min-xu-ai deleted the fwd_fwd_bwd_bwd branch September 24, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FSDP fails with multiple forward and then multiple backward calls
3 participants
@min-xu-ai @facebook-github-bot @flying-x