[minor] OSS: bring DDP in the benchmark #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
(the values in the benchmark regression test will need to be updated, that's expected. The current commit will fail because of that) |
min-xu-ai
approved these changes
Oct 8, 2020
benchmarks/oss.py
Outdated
| @@ -91,6 +94,7 @@ def train( | |||
| optimizer = ddp.optimizer | |||
| model = ddp | |||
| else: | |||
| model = DDP(model, device_ids=[rank]) | |||
There was a problem hiding this comment.
should we toggle find_unused_parameters to True/False and see its impacts?
There was a problem hiding this comment.
ahh, good point ! it was not yet up for review actually, looks like there's something wrong with SDP, looking into that :) I'll test this option
There was a problem hiding this comment.
oops, sorry, didn't notice that! :-)
|
looks like something is wrong in SDP depending on the world size, and this benchmark change exposed that |
…is correct wrt DDP, but SDP needs to be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
A suggestion from @msbaines on another PR made me think of that, the benchmark job that we had was not using DDP so not super realistic. The fake pictures were also the same on each rank, which prevents catching some sync issues, fixing that
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃