[chore] v0.1.7 #404
Merged
[chore] v0.1.7 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
min-xu-ai
approved these changes
Feb 19, 2021
min-xu-ai
reviewed
Feb 19, 2021
| @@ -4,7 +4,7 @@ | |||
| # LICENSE file in the root directory of this source tree. | |||
|
|
|||
| # Please update the doc version in docs/source/conf.py as well. | |||
There was a problem hiding this comment.
I resolved the conflict here.
|
It is interesting that at some point the release list stopped having the msgs about what's add and what's fixed. Do you know why? |
hmm no, good question ! I'll have a look. Must have been me not copy pasting the changelog in the release message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Packages a host of fixes in ShardedDDP raised by better unit testing, I think that it's worth it for many users who are not tracking master but installing via pip
Fixes #395 and #397 by adding the existing fix to the pip package eventually
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃