Update hubert config for compatibility to recent wav2vec2 update #4043
Conversation
|
Hi @ftshijt! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@arbabu123 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Are there any other issues related to the PR? I'm happy to modify the PR if you have any other suggestions. |
|
@ftshijt sorry I missed this. it looks good. i will merge this soon. thanks |
|
Hi @arbabu123 , may I know why the PR is closed? In fact, we have the dependency of fairseq in our toolkit, and this mismatch breaks our CI tests for a while, so we can only depend on the older version. We really want to keep updated with the latest repo, it would be very helpful to fix the issue |
|
@ftshijt sorry i didn't understand the issue. The fix has been landed and merged to master. What's the mismatch that you are talking about? What is the error that you are getting? |
This PR fixes #4035