New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging details for building against FAISS C++ API #669
Comments
Yes, the .o files are combined into libfaiss.a + libgpufaiss.a. |
Assuming the users build your source before building libraries that depend on it, Would it make sense to have FAISS install the so files into a common directory already on the LD path (e.g. We would also need to install the include files in |
Absolutely. IMO the proper paths would be
I will talk to @beauby on where we can standardize this an if we can distribute a binary package. |
Sounds good. I certainly don't mind providing a PR. |
The documentation describes that FAISS builds shared & static libraries but these do not appear to end up in the installed Python packaging. Rather, the Python conda packaging only installs the swig-converted artifacts.
If a codebase, dependent on FAISS, is being built against the libfaiss.so and/or libfaiss_gpu.so artifacts, this leaves developers with the option of forcing contributors to build FAISS themselves, or including the libs in the codebase.
Further clarification on the ideal way of packaging against FAISS C++ API's would be ideal.
The text was updated successfully, but these errors were encountered: