C API : ClusteringIterationStats integration #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
suggested changes
Mar 12, 2020
| @@ -75,14 +75,20 @@ FAISS_DECLARE_GETTER(Clustering, size_t, d) | |||
| /// getter for k | |||
| FAISS_DECLARE_GETTER(Clustering, size_t, k) | |||
|
|
|||
| FAISS_DECLARE_CLASS(ClusteringIterationStats) | |||
There was a problem hiding this comment.
While these lines will correctly declare the class and its getters, they won't provide an implementation. Attempting to call any of these methods would fail at link time. Please head over to Clustering_c.cpp and add them through the DEFINE_GETTER macro (should be easy to follow by example).
There was a problem hiding this comment.
done thanks !!
3f9b817
Co-Authored-By: Eduardo Pinho <enet4mikeenet@gmail.com>
Co-Authored-By: Eduardo Pinho <enet4mikeenet@gmail.com>
Co-Authored-By: Eduardo Pinho <enet4mikeenet@gmail.com>
Co-Authored-By: Eduardo Pinho <enet4mikeenet@gmail.com>
Enet4
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C Api : update Clustering iterations stats
fix #1139
based on #1139 (comment)