Some changes to simdlib #2885
Closed
Some changes to simdlib #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😕 |
wx257osn2
force-pushed
the
fix-simdlib_neon
branch
from
e2ee929
to
c67f521
Compare
|
@alexanderguzhva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@alexanderguzhva merged this pull request in 9c88422. |
Thejas-bhat
pushed a commit
to blevesearch/faiss
that referenced
this pull request
Sep 27, 2023
Summary:
- Use elementwise operation and reduction once instead of across-vector comparing operation twice
- Use already implemented supporting functions
- Unify semantics of `operator==` as same as `simd16uint16`
- `operator==` of `simd8uint32` and `simd8float32` had been implemented on facebookresearch#2568, but these has not same semantics as `simd16uint16` (which had been implemented in a long time ago). For getting the vector equality as `bool` , now we should use `is_same_as` member function.
- Change `is_same_as` to accept any vector type as argument for `simdlib_neon`
- `is_same_as` has supported any vector type on `simdlib_avx2` and `simdlib_emulated` already
- Remove unused function `simd16uint16::is_same` on `simdlib_avx2`
- Is it typo of `is_same_as` ? Anyway it seems to be used unlikely
Pull Request resolved: facebookresearch#2885
Reviewed By: mdouze
Differential Revision: D46330666
Pulled By: alexanderguzhva
fbshipit-source-id: 0ea14f8e9a8bda78f24a655219dffe3e07fc110f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator==as same assimd16uint16operator==ofsimd8uint32andsimd8float32had been implemented on Speedup exhaustive_L2sqr_blas for AVX2, ARM NEON and AVX512 #2568, but these has not same semantics assimd16uint16(which had been implemented in a long time ago). For getting the vector equality asbool, now we should useis_same_asmember function.is_same_asto accept any vector type as argument forsimdlib_neonis_same_ashas supported any vector type onsimdlib_avx2andsimdlib_emulatedalreadysimd16uint16::is_sameonsimdlib_avx2is_same_as? Anyway it seems to be used unlikely