Fix windows CI #2889
Closed
Fix windows CI #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC doesn't accept unsigned index with pragma omp parallel for
OpenMP (at least the specification) doesn't accept the expression includes a cast as loop condition with pragma omp parallel for
|
@wx257osn2 , thanks for your commit. Which MSVC version is this? |
|
@alexanderguzhva According to build log of CI,
|
|
@alexanderguzhva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@alexanderguzhva merged this pull request in bbc95b1. |
Thejas-bhat
pushed a commit
to blevesearch/faiss
that referenced
this pull request
Sep 27, 2023
Summary: facebookresearch#2882 added [a for loop, which has unsigned index, qualified with `#pragma omp parallel for`](https://github.com/facebookresearch/faiss/pull/2882/files#diff-5a89dcb99a1cce3f297c7f7dfc8e221306b281d4ced6dac1e0fc0fa54188195fR449-R452), but it seems that [MSVC doesn't support unsigned index with `#pragma omp parallel for`](https://app.circleci.com/pipelines/github/facebookresearch/faiss/4220/workflows/ee72de05-6ead-42d9-8ec5-44772e9fd41b/jobs/22529?invite=true#step-104-333) (I think this would not be conformed to OpenMP specification, but...) I (finally) change the loop with signed index. This changes introduce the precondition `n <= std::numeric_limits<std::make_signed_t<std::size_t>>::max()` , but usually this is `true` I think, so I just put this limitation as a comment instead of any `FAISS_ASSERT` or something like that. Pull Request resolved: facebookresearch#2889 Reviewed By: wickedfoo Differential Revision: D46325322 Pulled By: alexanderguzhva fbshipit-source-id: c68f4c8be3db188ac067e053c6c716e2896f75c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2882 added a for loop, which has unsigned index, qualified with
#pragma omp parallel for, but it seems that MSVC doesn't support unsigned index with#pragma omp parallel for(I think this would not be conformed to OpenMP specification, but...)I (finally) change the loop with signed index. This changes introduce the precondition
n <= std::numeric_limits<std::make_signed_t<std::size_t>>::max(), but usually this istrueI think, so I just put this limitation as a comment instead of anyFAISS_ASSERTor something like that.