Fix memory leak for ParameterSpace objects #3007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48404252 |
Summary: Pull Request resolved: facebookresearch#3007 There is a complicated interaction between SWIG and the python wrappers where the ownership of ParameterSpace arguments was stolen from Python. This diff adds a test, fixes that behavior and fixes the referenced_objects construction Differential Revision: D48404252 fbshipit-source-id: a502531157701e2939088fcfae2bfdb10818dbc9
|
This pull request was exported from Phabricator. Differential Revision: D48404252 |
mdouze
force-pushed
the
export-D48404252
branch
from
74d92d7
to
2ce7821
Compare
|
This pull request has been merged in 69cb877. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is a complicated interaction between SWIG and the python wrappers where the ownership of ParameterSpace arguments was stolen from Python.
This diff adds a test, fixes that behavior and fixes the referenced_objects construction
Differential Revision: D48404252