Skip to content

Commit

Permalink
Properly wire output for version string (#143)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #143

This did not follow the github syntax properly: https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs

Reviewed By: wuman

Differential Revision: D35126373

fbshipit-source-id: cffef664f5380fdff2041591a42c2fbe44938f75
  • Loading branch information
adshastri authored and facebook-github-bot committed Mar 24, 2022
1 parent a6c49d2 commit 79f3781
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ jobs:
tag_and_push:
runs-on: [self-hosted, e2e_test_runner]
needs: [private_attribution_e2e_test, private_lift_e2e_test]
needs: [build_prerelease_images, private_attribution_e2e_test, private_lift_e2e_test]
permissions:
contents: write
packages: write
Expand All @@ -340,7 +340,7 @@ jobs:
uses: mathieudutour/github-tag-action@v6.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
custom_tag: ${{ jobs.build_prerelease_images.outputs.version_tag }}
custom_tag: ${{ needs.build_prerelease_images.outputs.version_tag }}
tag_prefix: ""

- name: Set output
Expand Down

0 comments on commit 79f3781

Please sign in to comment.