Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making GCS Client Singleton #280

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Making GCS Client Singleton #280

wants to merge 3 commits into from

Conversation

achyutFB
Copy link
Contributor

Summary: Making the GCS Client a singleton

Differential Revision: D37853909

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 14, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37853909

achyutFB added a commit to achyutFB/fbpcf that referenced this pull request Jul 14, 2022
@achyutFB @facebook-github-bot
Making GCS Client Singleton (facebookresearch#280)
b20b0f0 
Summary:
Pull Request resolved: facebookresearch#280

Making the GCS Client a singleton

Differential Revision: D37853909

fbshipit-source-id: 89f7f603f51801f9c9980e94e33960efd6a403e4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37853909

wenhaizhumeta and others added 3 commits July 15, 2022 11:42
@wenhaizhumeta @facebook-github-bot
Expose GCP reader
55d4327 
Summary: Expose GCP reader

Differential Revision: D37727313

fbshipit-source-id: df0676f78c8d42535b3dff24fa4672644c124b90
@achyutFB @facebook-github-bot
Support GCP Uploader (facebookresearch#274)
b19781b 
Summary:
Pull Request resolved: facebookresearch#274

Implementing Resumable Uploads for GCS as Multipart upload using a cpp library is currently not available using GCP.
Changed earlier implementation of using S3 AWS multipart to now using GCP's resumable upload

Differential Revision: D37804966

fbshipit-source-id: 792447aee94939dfd040518f546758214f76c325
@achyutFB @facebook-github-bot
Making GCS Client Singleton (facebookresearch#280)
3f468d7 
Summary:
Pull Request resolved: facebookresearch#280

Making the GCS Client a singleton

Differential Revision: D37853909

fbshipit-source-id: 49293778ec8ef6da9ede5dff5f8561fcda31fbdc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37853909

@facebook-github-bot
Copy link
Contributor

Hi @achyutFB!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achyutFB @facebook-github-bot @wenhaizhumeta