Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix '-Wbitwise-instead-of-logical' in fbpcf/engine/test/SecretShareEngineTest.cpp #463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix '-Wbitwise-instead-of-logical' in fbpcf/engine/test/SecretShareEngineTest.cpp #463

wants to merge 1 commit into from

Commits on Jan 5, 2023

  1. Fix '-Wbitwise-instead-of-logical' in fbpcf/engine/test/SecretShareEn… 

    …gineTest.cpp

Summary:
LLVM-15 requires that we differentiate between `&&` and `&` as well as `||` and `|`. Logical operations are done with `&&` and `||` and bitwise operations are done with `&` and `|`. Confusing the two makes code harder to read and may lead to subtle bugs.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: meyering

Differential Revision: D42374522

fbshipit-source-id: 30bf80f8c58866b8cc5170b4c06172b98a13cc99
    @r-barnes @facebook-github-bot
    r-barnes authored and facebook-github-bot committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6025582 View commit details
    Browse the repository at this point in the history