Freeze FBPCP MPCInstance/MPCInstanceRepository changes #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Why In next couple weeks, I'm going to migrate mpc service from fbpcp to fbpcs. This is the first guard to avoid any further changes in fbpcp's mpc realted files detailed plan: https://docs.google.com/document/d/1qR1XVVCA2By95tldl2Ey9m__GKX3raodGAZ5yK9SCEw/edit?usp=sharing ## What - adding `test_mpc_do_not_change.py` to enforce code change freeze - adding `mpc_game.py` in do not change list ## Plan 1. migrate mpc service from fbpcp to fbpcs (this diff) 2. migrate mpc instance from fbpcp to fbpcs Differential Revision: https://internalfb.com/D41141813 fbshipit-source-id: c953583f044d8d6132328364c0c392c1e77b8aff
Summary: ## Why In next couple weeks, I'm going to migrate mpc service from fbpcp to fbpcs. This is the first guard to avoid any further changes in fbpcp's mpc realted files detailed plan: https://docs.google.com/document/d/1qR1XVVCA2By95tldl2Ey9m__GKX3raodGAZ5yK9SCEw/edit?usp=sharing ## What - added `test_mpc_do_not_change.py` to enforce code change freeze - adding `mpc_game_config.py` in do not change list Differential Revision: D41200589 fbshipit-source-id: 96aa8c0fc9846762b96ea1c52787f0934e150350
Summary: ## Why In next couple weeks, I'm going to migrate mpc service from fbpcp to fbpcs. This is the first guard to avoid any further changes in fbpcp's mpc realted files detailed plan: https://docs.google.com/document/d/1qR1XVVCA2By95tldl2Ey9m__GKX3raodGAZ5yK9SCEw/edit?usp=sharing ## What - added `MPCInstanceRepository` to enforce code change freeze - adding `MPCInstance` in do not change list Reviewed By: YigeZhu Differential Revision: D41203534 fbshipit-source-id: ec37625baf6a9caa5e11f54ecc7abd7421a9bfd6
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41203534 |
yutong-w
pushed a commit
to yutong-w/fbpcp
that referenced
this pull request
Nov 21, 2022
…mantic changes (facebookresearch#463) Summary: X-link: pytorch/torchx#463 Pull Request resolved: facebookresearch#294 X-link: facebookresearch/recipes#19 Pyre is going to have a semantic change in its configuration: D35695552. Basically, we are changing the default behavior on how search paths are discovered. Pre-existing configurations need to explicitly opt-in to the old behavior -- otherwise, they may risk breaking their type check setups. The added option will lead to a Pyre warning for now, but that warning would go away on the next Pyre upgrade. Reviewed By: stroxler Differential Revision: D35724336 fbshipit-source-id: b8156b9d3b5e5c7675b268d676e58c22be1c868e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Why
In next couple weeks, I'm going to migrate mpc service from fbpcp to fbpcs.
This is the first guard to avoid any further changes in fbpcp's mpc realted files
detailed plan: https://docs.google.com/document/d/1qR1XVVCA2By95tldl2Ey9m__GKX3raodGAZ5yK9SCEw/edit?usp=sharing
What
MPCInstanceRepositoryto enforce code change freezeMPCInstancein do not change listReviewed By: YigeZhu
Differential Revision: D41203534