allow input path override #1536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D39227358 fbshipit-source-id: 2088630c0805153c2147f72de6db19647b019151
Differential Revision: D39227339 fbshipit-source-id: bcc18c2268493645d219a601708f746af8b159d5
Differential Revision: D39229515 fbshipit-source-id: b5262ae3a279dc0cfe772c09548c9d09ef8c3490
Summary: ## What is this stack - Bolt has been used in canary for weeks now and we haven't seen reports of any issues - It's time to productionize - Early in the stack, I rework some logic to raise the quality bar a bit. At the end of the stack, I delete the legacy runner. ## What - When resuming a run, update the input path on the instance ## Why - This makes it so that advertisers who fail during input data validation can update their input file and continue the run (instead of having to wait for the instance to expire) Differential Revision: D39229715 fbshipit-source-id: 9ae7dada74232964a3e0cf5253a52e22ffca662e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39229715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
What is this stack
What
Why
Differential Revision: D39229715