Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to build WebGL without assimp. #148

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

msbaines
Copy link
Contributor

  • Speeds up WebGL build improving developer workflow.
  • Speeds up WebGL startup improving user experience.

Motivation and Context

  • Speeds up WebGL build improving developer workflow.
  • Speeds up WebGL startup improving user experience.

How Has This Been Tested

Verified locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Speeds up WebGL build improving developer workflow.
* Speeds up WebGL startup improving user experience.
@msbaines msbaines requested a review from mosra August 13, 2019 19:05
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 13, 2019
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Side note: USE_SYSTEM_ASSIMP is also a great productivity booster for when you actually need it. Try it out (brew install assimp) and watch the improved compile times :)

@msbaines msbaines merged commit 2ad23a0 into master Aug 13, 2019
@msbaines msbaines deleted the no-assimp branch August 13, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants