Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL: Add support for setting initial position and location. #168

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

msbaines
Copy link
Contributor

Motivation and Context

This is required for reproducibility.

How Has This Been Tested

Verified that agent is now always in the same location at start.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 21, 2019
@angelxuanchang
Copy link
Contributor

This is useful functionality and the changes looks pretty good. My one suggestion would be to rename the this.state in simenv_embind.js to this.initialAgentState (to make it clear that is it agent state and that is used in reset). Other comment is that we need to start to have more documentation - in this case, specify what happens with unspecified parameters in the agent state (such as velocity, force, etc - I believe they are all set to 0).

@msbaines
Copy link
Contributor Author

This is useful functionality and the changes looks pretty good. My one suggestion would be to rename the this.state in simenv_embind.js to this.initialAgentState (to make it clear that is it agent state and that is used in reset). Other comment is that we need to start to have more documentation - in this case, specify what happens with unspecified parameters in the agent state (such as velocity, force, etc - I believe they are all set to 0).

Yes, initialAgentState is much clear. Will add documentation in a separate change. I am thinking of using JSDoc annotations and documentationjs for the documentation generation.

Copy link
Collaborator

@msavva msavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants