--[BE Week] Minimize logging spam #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Awesome! Thanks for tackling this! |
eundersander
approved these changes
Jun 27, 2023
src/esp/core/Logging.h
Outdated
| * shows things that are generally useful. These names exist such that logging | ||
| * levels can be added and removed without users needed to change what they set | ||
| * logging to. | ||
| * The convience levels, @ref Verbose, @ref Default and @ref Quiet are the primary user facing |
jturner65
changed the title
E:Error; W:Warning; D:Debug; V:VeryVerbose.
jturner65
force-pushed
the
BE_LoggingSpam
branch
from
56c76d6
to
9e2f090
Compare
In decreasing severity order : 'Error', 'Warning', 'Debug', 'Message'(for very verbose)
jturner65
force-pushed
the
BE_LoggingSpam
branch
from
9b1a9c2
to
db71faf
Compare
jturner65
force-pushed
the
BE_LoggingSpam
branch
from
29998fa
to
1a921ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The default logging behavior in habitat-sim has been overwhelming for some time now. So much debug information is displayed to the console that any important warnings or errors get lost in the noise. This PR is intended to address this issue.
Habitat-sim supports 4 logging levels : VERY_VERBOSE, DEBUG, WARNING and ERROR. The intended purpose of these logging level messages is as follows :
This PR is geared toward making adjustments to the logging behavior of habitat-sim in order to make console output less overwhelming and more useful. The main changes are as follows :
NOTE : Users can still modify their logging level to get more or fewer messages from the simulator by following the guidelines on this page.
To give an idea of the changes in this PR, before this PR's changes, loading a Floorplanner scene would yield over 45k messages to the console. With the changes in this PR, loading the same scene now prints 4 messasges. Note : all of the information -can- still be printed to the console if desired (if hunting down a bug, for instance) but the user would have to specify a more verbose logging level as in the instructions here.
How Has This Been Tested
C++ and python tests pass. The logging test needed to be slightly modified.
Types of changes
Checklist