Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS build doc. #2162

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Update JS build doc. #2162

merged 1 commit into from
Sep 22, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jul 20, 2023 •
edited

Motivation and Context

This provides the JS documentation with up-to-date setup commands.

How Has This Been Tested

The commands were tested on a new configuration.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested a review from eundersander July 20, 2023 03:00
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 20, 2023
@0mdc 0mdc marked this pull request as ready for review September 22, 2023 15:29
jturner65
jturner65 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit 6ced00b into main Sep 22, 2023
10 checks passed
@0mdc 0mdc deleted the update-js-build-doc branch September 22, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0mdc @jturner65 @facebook-github-bot