Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default python viewer dataset to 'default'. #2287

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Change default python viewer dataset to 'default'. #2287

merged 1 commit into from
Dec 20, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 20, 2023

Motivation and Context

This changes the default dataset to "default", removing a dependency to ycb and matching the behavior of viewer.cpp.

How Has This Been Tested

Tested locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@0mdc 0mdc requested a review from jturner65 December 20, 2023 16:24
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 20, 2023
jturner65
jturner65 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit aa60ab7 into main Dec 20, 2023
4 of 10 checks passed
@0mdc 0mdc deleted the default-py-viewer-dataset branch December 20, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0mdc @jturner65 @facebook-github-bot