[tests] Setup JS Visual Regression Testing #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use jest-image-snapshot to generate and compare snapshots - Use puppeteer to launch chromium browser in headless mode - Use finalhandler and static-serve to finalize requests and serve static content easily - Update package.json with required packages
facebook-github-bot
added
the
CLA Signed
msbaines
approved these changes
Dec 18, 2019
src/esp/bindings_js/tests/server.js
Outdated
| await new Promise(resolve => server.close(resolve)); | ||
| } | ||
|
|
||
| export async function generateImage(path) { |
mosra
reviewed
Dec 18, 2019
msbaines
reviewed
Dec 20, 2019
| await new Promise(resolve => server.close(resolve)); | ||
| } | ||
|
|
||
| export async function generateImage(path) { |
msbaines
approved these changes
Dec 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 53.86% 54.01% +0.15%
==========================================
Files 164 165 +1
Lines 7719 7751 +32
Branches 82 84 +2
==========================================
+ Hits 4158 4187 +29
- Misses 3561 3564 +3
Continue to review full report at Codecov.
|
eundersander
pushed a commit
to eundersander/habitat-sim
that referenced
this pull request
Aug 6, 2020
* added gibson large generation script * ran black for formatting * updated number of episodes, moved to ddppo directory * updated license to include data generation * added header * changed const to upper case * added separate function call * Update README.md Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com> Co-authored-by: Santhosh K. Ramakrishnan <sramarki@fb.com> Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com>
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
- Use jest-image-snapshot to generate and compare snapshots - Use puppeteer to launch chromium browser in headless mode - Use finalhandler and static-serve to finalize requests and serve static content easily - Update package.json with required packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static content easily
Motivation and Context
Visual Regression Testing is a good way to catch regressions in the code. In JS specifically, since we are rendering on browser side, things should be consistent. The PR aims to introduce first test that uses visual regression testing.
How Has This Been Tested
npm testTypes of changes
Checklist