Bool values are not numeric (#51)

Co-authored-by: danthe3rd <danthe3rd@users.noreply.github.com>
facebookresearch · Apr 14, 2020 · 3fddaa9 · 3fddaa9
1 parent 4f91284
commit 3fddaa9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/hiplot/fetchers_demo.py b/hiplot/fetchers_demo.py
@@ -152,6 +152,13 @@ def demo_distribution(**kwargs: Any) -> hip.Experiment:
     return xp
 
 
+def demo_bool() -> hip.Experiment:
+    return hip.Experiment.from_iterable([
+        {"bool": True},
+        {"bool": False}
+    ])
+
+
 README_DEMOS: Dict[str, Callable[[], hip.Experiment]] = {
     "demo": demo,
     "demo_big": lambda: demo(1000),
@@ -163,4 +170,5 @@ def demo_distribution(**kwargs: Any) -> hip.Experiment:
     "demo_distribution_cat": lambda: demo_distribution(axis="cat"),
     "demo_distribution_num": lambda: demo_distribution(axis="numeric"),
     "demo_distribution_num_100bins": lambda: demo_distribution(axis="numeric", nbins=100),
+    "demo_bool": demo_bool,
 }
diff --git a/src/infertypes.ts b/src/infertypes.ts
@@ -164,7 +164,9 @@ export function infertypes(url_states: PersistentState, table: Array<Datapoint>,
             } else {
                 setVals.push(v);
             }
-            if (typeof v != "number" && !is_special_num && isNaN(v)) {
+            // Detect non-numeric column
+            if ((typeof v != "number" && !is_special_num && isNaN(v)) ||
+                    v === true || v === false) {
                 numeric = false;
                 return;
             }