address comments

facebookresearch · Mar 25, 2022 · 8d83fdb · 8d83fdb
1 parent 57b44b3
commit 8d83fdb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/hydra/main.py b/hydra/main.py
@@ -31,14 +31,14 @@ def _get_rerun_conf(file_path: str, overrides: List[str]) -> DictConfig:
 
     with open(str(file), "rb") as input:
         config = pickle.load(input)  # nosec
-        configure_log(config.hydra.job_logging, config.hydra.verbose)
-        HydraConfig.instance().set_config(config)
-        task_cfg = copy.deepcopy(config)
-        with read_write(task_cfg):
-            with open_dict(task_cfg):
-                del task_cfg["hydra"]
-        assert isinstance(task_cfg, DictConfig)
-        return task_cfg
+    configure_log(config.hydra.job_logging, config.hydra.verbose)
+    HydraConfig.instance().set_config(config)
+    task_cfg = copy.deepcopy(config)
+    with read_write(task_cfg):
+        with open_dict(task_cfg):
+            del task_cfg["hydra"]
+    assert isinstance(task_cfg, DictConfig)
+    return task_cfg
 
 
 def main(

diff --git a/website/docs/experimental/rerun.md b/website/docs/experimental/rerun.md
@@ -36,6 +36,7 @@ def my_app(cfg: DictConfig) -> None:
 
 Run the example app:
 ```commandline
+$ python my_app.py
 [2022-03-16 14:51:30,905][hydra.experimental.pickle_job_info_callback][INFO] - Saving job configs in /Users/jieru/workspace/hydra/examples/experimental/outputs/2022-03-16/14-51-30/.hydra/config.pickle
 [2022-03-16 14:51:30,906][__main__][INFO] - Output_dir=/Users/jieru/workspace/hydra/examples/experimental/outputs/2022-03-16/14-51-30
 [2022-03-16 14:51:30,906][__main__][INFO] - cfg.foo=bar
@@ -45,10 +46,8 @@ The Callback saves `config.pickle` in `.hydra` sub dir, this is what we will use
 
 Now rerun the app
 ```commandline
-# OUTPUT_DIR=/Users/jieru/workspace/hydra/examples/experimental/outputs/2022-03-16/14-51-30/.hydra/
-
+$ OUTPUT_DIR=/Users/jieru/workspace/hydra/examples/experimental/outputs/2022-03-16/14-51-30/.hydra/
 $ python my_app.py --experimental-rerun $OUTPUT_DIR/config.pickle
-
 /Users/jieru/workspace/hydra/hydra/main.py:23: UserWarning: Experimental rerun CLI option.
   warnings.warn(msg, UserWarning)
 [2022-03-16 14:59:21,666][__main__][INFO] - Output_dir=/Users/jieru/workspace/hydra/examples/experimental/outputs/2022-03-16/14-51-30