You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1011 reports performance regression in Adam when using instantiate.
The root cause appears to be that ListConfig is used to configure the betas where tuple or list would be more performant.
Adam is accessing the betas twice per layer during the optimization, which - in some scenarios - is enough to cause a speed regression.
The text was updated successfully, but these errors were encountered:
To address this, a new instantiation parameter is added:
_convert_ : [none, partial, all]
The parameter can be a par t of the provided conifig or can be specified in the callsite to instanitate.
_convert_: none : Keep current behavior, passed parameters are DictConfig and ListConfig objects. This is the default behavior for when _convert_ is not specified.
_convert_ : partial : convert to primitive containers, with the exception of Structured Configs and their nested objects
_convert_ : all : complete conversion to primitive containers.
#1011 reports performance regression in Adam when using instantiate.
The root cause appears to be that ListConfig is used to configure the betas where tuple or list would be more performant.
Adam is accessing the betas twice per layer during the optimization, which - in some scenarios - is enough to cause a speed regression.
The text was updated successfully, but these errors were encountered: