Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Plugins from Singleton get_state, fix ray launcher default key pair name #1330

Merged
merged 4 commits into from Jan 27, 2021
Merged

remove Plugins from Singleton get_state, fix ray launcher default key pair name #1330

merged 4 commits into from Jan 27, 2021

Conversation

jieru-hu
Copy link
Contributor

remove Plugins from Singleton get_state (#1312)
fix key pair name - add user (#1309)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2021
@jieru-hu jieru-hu marked this pull request as draft January 23, 2021 01:16
@omry
Copy link
Collaborator

omry commented Jan 23, 2021

Are you planning on releasing hydra 1.0.6 for this?
if so, you should include a news fragment.

@jieru-hu jieru-hu changed the title cherry-pick #1312 #1309 remove Plugins from Singleton get_state, fix ray launcher default key pair name Jan 26, 2021
@jieru-hu jieru-hu marked this pull request as ready for review January 26, 2021 23:08
omry
omry requested changes Jan 26, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@jieru-hu
Copy link
Contributor Author

Are you planning on releasing hydra 1.0.6 for this?
if so, you should include a news fragment.

ah I see, i checked https://github.com/facebookresearch/hydra/tree/1.0_branch/news before this and didnt see anything under there so I thought 1.0_branch behaves differently. will fix.

@jieru-hu
Copy link
Contributor Author

Are you planning on releasing hydra 1.0.6 for this?
if so, you should include a news fragment.

ah I see, i checked https://github.com/facebookresearch/hydra/tree/1.0_branch/news before this and didnt see anything under there so I thought 1.0_branch behaves differently. will fix.

nvm, should have checked here https://github.com/facebookresearch/hydra/blob/a8daf4823fb4b155f55fa9ada13394423e8cbfed/website/versioned_docs/version-1.0/development/documentation.md

@omry
Copy link
Collaborator

omry commented Jan 26, 2021

Are you planning on releasing hydra 1.0.6 for this?
if so, you should include a news fragment.

ah I see, i checked https://github.com/facebookresearch/hydra/tree/1.0_branch/news before this and didnt see anything under there so I thought 1.0_branch behaves differently. will fix.

Release branch is supposed to be stable, so no news is good news :)

omry
omry approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated comments a bit.
feel free to merge once CI passes.

@jieru-hu jieru-hu merged commit b0a5b2a into facebookresearch:1.0_branch Jan 27, 2021
@jieru-hu jieru-hu deleted the ray_changes branch January 27, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omry omry omry approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jieru-hu @omry @facebook-github-bot