[ray launcher] fix key pair name - add user #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jieru-hu
changed the title
omry
reviewed
Jan 19, 2021
| @@ -58,7 +58,9 @@ class RayProviderConf: | |||
| region: str = "us-west-2" | |||
| availability_zone: str = "us-west-2a,us-west-2b" | |||
| cache_stopped_nodes: bool = False | |||
| key_pair: Dict[str, str] = field(default_factory=lambda: {"key_name": "hydra"}) | |||
| key_pair: Dict[str, str] = field( | |||
| default_factory=lambda: {"key_name": "hydra-${env:USER,me}"} | |||
There was a problem hiding this comment.
Why is "me" a good default value for a key name?
There was a problem hiding this comment.
probably not a good name :) how about just user?
There was a problem hiding this comment.
right now the key name is hydra-{$USER}, are you saying is $USER does not exist we do hydra-hydra?
There was a problem hiding this comment.
I'm going to name it hydra-${env:USER, user} then :)
jieru-hu
added a commit
to jieru-hu/hydra
that referenced
this pull request
Jan 23, 2021
jieru-hu
added a commit
to jieru-hu/hydra
that referenced
this pull request
Jan 27, 2021
jieru-hu
added a commit
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now the default key-pair name is
hydra. However this won't work well if multiple users share one aws account - they won't be able to share the key pair with same names in the same account (easily.)Have you read the Contributing Guidelines on pull requests?
Yes/No
Test Plan
Verified locally the variable was interpreted correctly and example applications run.
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)