Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 support #2304

Closed
dolfinus opened this issue Jul 19, 2022 · 5 comments 路 Fixed by #2523
Closed

Drop Python 3.6 support #2304

dolfinus opened this issue Jul 19, 2022 · 5 comments 路 Fixed by #2523
Labels
enhancement Enhanvement request

Comments

@dolfinus
Copy link
Contributor

dolfinus commented Jul 19, 2022

馃殌 Feature Request

How about dropping Python 3.6 support?

Motivation

Is your feature request related to a problem? Please describe.

Python 3.6 reached end of life 23 Dec 2021, and will no longer receive updates and bugfixes

Pitch

Describe the solution you'd like

Let's drop Python 3.6 support from the package and from CI/linters/etc.

@dolfinus dolfinus added the enhancement Enhanvement request label Jul 19, 2022
@Jasha10
Copy link
Collaborator

Jasha10 commented Jul 19, 2022

@dolfinus see omry/omegaconf#791.

@pixelb
Copy link
Contributor

pixelb commented Jul 21, 2022

Note we can monitor python minor version usage at:
https://pypistats.org/packages/hydra-core

@pixelb
Copy link
Contributor

pixelb commented Jul 25, 2022

Also it's worth noting that python 3.6 is the centos 8 official version, which means longer support than would normally be provided a version

@dolfinus
Copy link
Contributor Author

dolfinus commented Oct 24, 2022

Also it's worth noting that python 3.6 is the centos 8 official version

CentOS 8 have a python3.8 package as well as 3.6. Also in case of development environment, pyenv is a common solution which allows to use any python version user wants without making any changes to list of OS packages.

@Jasha10
Copy link
Collaborator

Jasha10 commented Nov 27, 2022

It's become onerous to support some CI with python3.6. Mypy no longer has official support for 3.6.
In PR #2472 I disable lints for python3.6. The core tests are still working well enough with 3.6, so I'll leave those intact for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhanvement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants