-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider dropping formal Python 3.6 support for OmegaConf 2.2 #791
Comments
EOL is Dec 23rd, 2021 |
The main thing to consider here is usage on popular systems. |
Sounds good. $ python3.6
...
>>> import pickle
>>> from typing import Optional
>>> pickle.dumps(Optional[int])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
_pickle.PicklingError: Can't pickle typing.Union[int, NoneType]: it's not the same object as typing.Union This comes up in particular with OmegaConf containers that have an optional element_type, e.g. containers typed as |
I think we should feel comfortable dropping 3.6. |
python-attrs (which is a core dependency of omegaconf) has deprecated support for python3.6. This which is causing Hydra CI failure
As a first step, I'll remove the python3.6 classifier from the Hydra setup.py file and will disable the py3.6 CI job. |
Python 3.6 eol is coming in a couple of months: https://endoflife.date/python
Originally posted by @omry in #749 (comment)
The text was updated successfully, but these errors were encountered: