Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Skip certain files during plugin discovery #494

Closed
shagunsodhani opened this issue Mar 12, 2020 · 2 comments
Closed

[Feature Request] Skip certain files during plugin discovery #494

shagunsodhani opened this issue Mar 12, 2020 · 2 comments
Assignees
Labels
enhancement Enhanvement request

Comments

@shagunsodhani
Copy link
Contributor

shagunsodhani commented Mar 12, 2020

馃殌 Feature Request

When scanning the plugins directory, certain files should be skipped.

Motivation

Is your feature request related to a problem? Please describe.

Plugin discovery imports all the modules in the plugins directory. This can slow down Hydra startup. One example is Ax plugin slowing down Hydra #476

Pitch

Describe the solution you'd like
When scanning plugins, ignore files starting with "_".

Describe alternatives you've considered

  • We could put certain files outside the plugins directory but that separates the logic that should live together.

Are you willing to open a pull request? (See CONTRIBUTING)

Yes :)

Additional context

Add any other context or screenshots about the feature request here.

NA

@shagunsodhani
Copy link
Contributor Author

Fixed in 67a525b

@omry
Copy link
Collaborator

omry commented Mar 22, 2020

Next time you can put a "closes #494" in the PR, and it will get closed automatically when it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhanvement request
Projects
None yet
Development

No branches or pull requests

2 participants