Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of defaults list and hydra node regardless of node schema #877

Closed
omry opened this issue Aug 14, 2020 · 0 comments · Fixed by #878
Closed

Allow overriding of defaults list and hydra node regardless of node schema #877

omry opened this issue Aug 14, 2020 · 0 comments · Fixed by #878

Comments

@omry
Copy link
Collaborator

omry commented Aug 14, 2020

Given this primary config node:

@dataclass
class Config(DictConfig):
  name: str = MISSING
  age: int = MISSING

cs = ConfigStore.instance()
cs.store(name="config", node=Config)

It does not mention the hydra node or the defaults list.
This means that overriding either from the corresponding config.yaml file will be rejected per the schema.

Those two fields should be whitelisted to allow the following config.yaml to be validated against this schema without issues.

# defaults list
defaults:
  - hydra/job_logging: disabled

# hydra node
hydra:
  job:
    name: test

# and some user config
name: foo
age: 12
@omry omry mentioned this issue Aug 16, 2020
@omry omry closed this as completed Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant