Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for overriding to sub-structured config (#1515) #1516

Closed
wants to merge 1 commit into from
Closed

Fix for overriding to sub-structured config (#1515) #1516

wants to merge 1 commit into from

Conversation

strx2322
Copy link

@strx2322 strx2322 commented Mar 29, 2021 •
edited

Overriding variable to sub-structured config fails when using CLI

Motivation

#1515

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

please run the code in issue #1515

@strx2322
Fix for overriding to sub-structured config (facebookresearch#1515)
04a0ef7 
Overriding variable to sub-structured config fails when using CLI
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2021
@omry
Copy link
Collaborator

omry commented Apr 10, 2021

Thanks for the PR.
#1549 contains a proper fix (that depends on a new feature in OmegaConf.update().

Closing this one in favor of #1549.

@omry omry closed this Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@strx2322 @omry @facebook-github-bot