Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support target keyword in instantiate API #1673

Merged
merged 1 commit into from
Jun 17, 2021
Merged

support target keyword in instantiate API #1673

merged 1 commit into from
Jun 17, 2021

Conversation

jieru-hu
Copy link
Contributor

Closes #1669

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2021
@jieru-hu jieru-hu requested review from omry and Jasha10 June 15, 2021 19:35
Jasha10
Jasha10 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

omry
omry approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jieru-hu jieru-hu merged commit 52905a6 into facebookresearch:master Jun 17, 2021
@jieru-hu jieru-hu deleted the 1669 branch July 20, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omry omry omry approved these changes

@Jasha10 Jasha10 Jasha10 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot use target kwarg when instantiating with hydra.utils.instantiate()
4 participants
@jieru-hu @omry @Jasha10 @facebook-github-bot