Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydra.mode config #2085

Merged
merged 3 commits into from Mar 16, 2022
Merged

Add hydra.mode config #2085

merged 3 commits into from Mar 16, 2022

Conversation

jieru-hu
Copy link
Contributor

Closes #394

Users should be able to configure hydra.mode=RUN|MULTIRUN to control the application behavior.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2022
@jieru-hu jieru-hu requested a review from Jasha10 March 14, 2022 17:45
@jieru-hu jieru-hu requested a review from pixelb March 15, 2022 18:11
Copy link
Contributor

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. thanks!

hydra/_internal/utils.py Outdated Show resolved Hide resolved
@jieru-hu jieru-hu requested a review from pixelb March 15, 2022 19:13
Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jieru-hu jieru-hu merged commit ec74c47 into facebookresearch:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow multirun default through config
4 participants