drop py3.7 & fix CI #2854
drop py3.7 & fix CI #2854
Conversation
Previously, the `configen` utility had a vendored version of the `omegaconf._utils.type_str` function. Originally, the behavioral differences between the vendored `configen.utils.type_str` function and omegaconf's `type_str` were minimal, differing only on an ellipsis input `...`. Later, the two functions converged in this regard, as `omegaconf._utils.type_str` added support for ellipsis input. Given that the two functions converged, we can drop the vendored version of `type_str` from `configen` and instead use `omegaconf._utils.type_str` directly.
facebook-github-bot
added
the
CLA Signed
|
This PR supersedes PR #2853. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Awesome, thanks a lot for tackling this!
Just one comment besides the small ones below: would it be possible to use the same versions of the linter libraries as OmegaConf in requirements/dev.txt, and use that for formatting? (if needed you can upgrade those in OmegaConf as well). This will make things easier and more consistent for developers.
Sure, I've updated pins on the linters in commit 08b6912 and have opened a corresponding OmegaConf PR omry/omegaconf#1159. |
Drop support for python3.7 and fix CI failures
This PR makes the following changes:
omegaconf._utils.type_strdirectly instead of vendoringtype_strReviewers may wish to view commits one-by-one.
Closes #2852.