Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails missing requirement #85

Closed
omrihaber opened this issue Jul 14, 2021 · 1 comment
Closed

CI fails missing requirement #85

omrihaber opened this issue Jul 14, 2021 · 1 comment

Comments

@omrihaber
Copy link
Contributor

I saw the CI failing because of a library called deprecated which is missing from the requirements.txt

Made a PR that adds the requirement.

Should these requirements be separate from the requirements.txt and create a test_requirements.txt or all of the dependencies for testing and development are stated at requirements.txt?

@michaelbrundage
Copy link
Contributor

Good catch, thanks -- that was my error. I thought I had added it to requirements.txt, but apparently not. For now, we don't have separate requirements and test requirements, and for this instance it belongs in requirements.txt regardless. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants