Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

add finetune from detectron guide #286

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

wangg12
Copy link
Contributor

@wangg12 wangg12 commented Dec 18, 2018

#15

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 18, 2018
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

There is only one thing I'd add, and then this is good to merge!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit a0d6edd into facebookresearch:master Dec 18, 2018
@DIYer22
Copy link
Contributor

DIYer22 commented Jan 3, 2019

How about auto-remove the keys when shape not match, and raise a warning to tell user.
If I pull a PR to auto-remove . Will the PR be accepted? @fmassa

@fmassa
Copy link
Contributor

fmassa commented Jan 3, 2019

@DIYer22 I think that the error as we have now is the safest option at the moment.
We already log a number of things during training, and a warning could easily be missed, but training would go on but results would be worse.

nprasad2021 pushed a commit to nprasad2021/maskrcnn-benchmark that referenced this pull request Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants