This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fixing build-errors on Windows #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eilDiv. Adding type-cast to (long) to first parameter to fix the errors.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This was referenced Feb 6, 2019
This was referenced May 1, 2019
wswday
added a commit
to wswday/mmdetection
that referenced
this pull request
Jul 13, 2019
1.Adding 'cxx' key for extra_compile_args 2.Adding type-cast to long for first parameter of THCCeilDiv facebookresearch/maskrcnn-benchmark#409 3.Ignoring resource setting on windows
hellock
pushed a commit
to open-mmlab/mmdetection
that referenced
this pull request
Jul 13, 2019
* Fixing build-errors on Windows (add some compile args, which are default on Linux) * Fixing build-errors on Windows * minor formatting * Fixing errors on windows 1.Adding 'cxx' key for extra_compile_args 2.Adding type-cast to long for first parameter of THCCeilDiv facebookresearch/maskrcnn-benchmark#409 3.Ignoring resource setting on windows * update the order of import statements
Lyears
pushed a commit
to Lyears/maskrcnn-benchmark
that referenced
this pull request
Jun 28, 2020
…eilDiv. Adding type-cast to (long) to first parameter to fix the errors. (facebookresearch#409)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build-errors on Windows caused by invalid types when calling THCC……eilDiv. Adding type-cast to (long) to first parameter to fix the errors.
Resolved issue: #254
Simpler alternative to: #271