Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MyPy type checking to CI #14

Closed
m3rlin45 opened this issue Mar 29, 2022 · 3 comments
Closed

Add MyPy type checking to CI #14

m3rlin45 opened this issue Mar 29, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@m3rlin45
Copy link
Contributor

m3rlin45 commented Mar 29, 2022

馃殌 Feature Request

let's have typechecking, like in ParlAI: https://github.com/fairinternal/ParlAI-Internal/blob/705258b5799e69ef8942a8fc56928ad779e0980b/.github/workflows/lint.yml

Motivation

It would be good to have some type checks (as suggestions, not a blocking test) to help catch common errors

Pitch

probably can just copy/past from ParlAI:
https://github.com/fairinternal/ParlAI-Internal/blob/705258b5799e69ef8942a8fc56928ad779e0980b/.github/workflows/lint.yml

https://fb.workplace.com/100020258253907/posts/744791912872744/
Some slides about the ParlAI version

@m3rlin45 m3rlin45 added enhancement New feature or request help wanted good first issue Good for newcomers labels Mar 29, 2022
@bigfootjon bigfootjon transferred this issue from another repository May 2, 2022
@TommyDew42
Copy link
Contributor

Hi! It looks like a very good issue I can contribute. Is it possible I can pick this up?

@stephenroller
Copy link
Contributor

Please Tommy, we would welcome!

@punitkoura
Copy link
Contributor

Looks like this is done, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants