Add MyPy to CI #103
Merged
Add MyPy to CI #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/lint.yml
Outdated
| - name: Type Checking with MyPy | ||
| run: | | ||
| pip install mypy | ||
| mypy |
There was a problem hiding this comment.
Lets make this || true for now. Mypy is best as a warning not an error in its current state
There was a problem hiding this comment.
Sounds great!
The CI would now looks like this
TommyDew42
requested review from
suchenzang,
anj-s,
ngoyal2707,
punitkoura,
moyapchen and
m3rlin45
as code owners
suchenzang
reviewed
May 17, 2022
mypy.ini
Outdated
| @@ -0,0 +1,5 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
There was a problem hiding this comment.
I believe we have python 3.8 dependency in our CI setup - could we change this to 3.8 instead?
suchenzang
approved these changes
May 17, 2022
|
Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch Description
PR for issue 14.
Here we add MyPy to CI.
Testing steps
Run
mypyat local laptop & run the check via an actual pull request.