Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fixed] Add quote for train_cmd in metaseq/launcher/slurm.py #44

Merged
merged 1 commit into from
May 5, 2022

Conversation

wkcn
Copy link
Contributor

@wkcn wkcn commented May 5, 2022

Hi there, thanks for your great work!
I found that there is no quote for train_cmd in metaseq/launcher/slurm.py.
It leads to an issue that dry-run prints a command without quote, namely --adam-betas (0.9, 0.95), which could not run directly. The correct command should be --adam-betas '(0.9, 0.95)'.

Patch Description
Add quote for train_cmd in the function gen_train_command of metaseq/launcher/slurm.py.
The command --adam-betas (0.9, 0.95) will be fixed to --adam-betas '(0.9, 0.95)' in this PR : )

Testing steps
Run the following command to print the dry-run message.

opt-baselines \
  -n 1 -g 2 \
  -p test_v0 \
  --model-size 125m \
  --azure \
  --data ./dataset \
  --checkpoints-dir "./outputs" \
  --local \
  --dry-run

@suchenzang suchenzang merged commit 2d5e753 into facebookresearch:main May 5, 2022
suchenzang added a commit that referenced this pull request May 8, 2022
@suchenzang
Copy link
Contributor

This commit is being reverted in #69. Opened an issue to add an integration test to catch these errors before merging: #68

m3rlin45 pushed a commit that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants