[Bug Fixed] Add quote for train_cmd
in metaseq/launcher/slurm.py
#44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for your great work!
I found that there is no quote for
train_cmd
inmetaseq/launcher/slurm.py
.It leads to an issue that
dry-run
prints a command without quote, namely--adam-betas (0.9, 0.95)
, which could not run directly. The correct command should be--adam-betas '(0.9, 0.95)'
.Patch Description
Add quote for
train_cmd
in the functiongen_train_command
ofmetaseq/launcher/slurm.py
.The command
--adam-betas (0.9, 0.95)
will be fixed to--adam-betas '(0.9, 0.95)'
in this PR : )Testing steps
Run the following command to print the
dry-run
message.opt-baselines \ -n 1 -g 2 \ -p test_v0 \ --model-size 125m \ --azure \ --data ./dataset \ --checkpoints-dir "./outputs" \ --local \ --dry-run