Auto-delete checkpoints #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchenzang
force-pushed
the
auto_delete_checkpoints
branch
from
169216e
to
ce8c340
Compare
Open
suchenzang
force-pushed
the
auto_delete_checkpoints
branch
from
3e0735e
to
cbff7b8
Compare
urielsinger
reviewed
Mar 13, 2023
suchenzang
force-pushed
the
auto_delete_checkpoints
branch
from
0c5db28
to
9c92e4e
Compare
Merged
suchenzang
requested review from
ngoyal2707,
punitkoura,
moyapchen,
klshuster,
ruanslv,
davides,
igormolybogFB,
Xirider,
andrewPoulton and
bashnick
as code owners
davides
approved these changes
Mar 30, 2023
|
Yay thank you for carrying the team on this @davides !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entirely fixed and shipped by @davides !
Adding back logic that was removed in refactoring (see: https://github.com/facebookresearch/fairseq/blob/0338cdc3094ca7d29ff4d36d64791f7b4e4b5e6e/fairseq/checkpoint_utils.py#L142-L192 and https://github.com/facebookresearch/fairseq/blob/0338cdc3094ca7d29ff4d36d64791f7b4e4b5e6e/fairseq/checkpoint_utils.py#L538-L557) for OG history.
Brought back in by @urielsinger in #668.