Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#64 issue solved: Fix access from base.py to nethack _vardir #65

Closed
wants to merge 1 commit into from

Conversation

GeremiaPompei
Copy link
Contributor

#64 issue solved: Fix access from base.py to nethack _vardir.
I tested the modification on my local project.
Seem that before this modification the library wasn't able to run because there was an access to self.env._vardir instead of self.nethack._vardir.

@facebook-github-bot
Copy link

Hi @GeremiaPompei!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions bot added the core label Dec 1, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@samvelyan
Copy link
Member

Thanks @GeremiaPompei for your contribution. However, this issue required more changes so I moved your commit to #66 which also includes additional changes.

@samvelyan samvelyan closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants