Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chores] Upgrade to pytorch 1.6 and torchvision 0.7 #546

Closed
wants to merge 2 commits into from
Closed

[chores] Upgrade to pytorch 1.6 and torchvision 0.7 #546

wants to merge 2 commits into from

Conversation

vedanuj
Copy link
Contributor

@vedanuj vedanuj commented Sep 6, 2020

  • Upgrading to pytorch 1.6, which comes with new features required for upcoming torchscript changes
  • Optimizer keys are no longer non-deterministic in PT1.6, check pytorch PR. Remove skip_keys check from checkpoint optimizer tests.
  • Fixed nucleus sampling tests
  • Update docs to reflect support for pytorch 1.6
  • Update CI tests, CircleCI and Actions to use pytorch 1.6, torchvision 0.7

Test Plan :

  • Tested with visual bert and mmbt models on Hateful Memes
  • Running internally at FB (runs on pytorch master)

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 6, 2020
facebook-github-bot
facebook-github-bot reviewed Sep 6, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedanuj has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedanuj has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

apsdehal
apsdehal approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@apsdehal apsdehal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating.

@facebook-github-bot
Copy link
Contributor

@vedanuj merged this pull request in 584e26d.

@vedanuj vedanuj deleted the torch_upgrade branch September 11, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@apsdehal apsdehal apsdehal approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vedanuj @facebook-github-bot @apsdehal