Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 'misc' observation with input mode indicators #180

Merged
merged 1 commit into from Jun 23, 2021

Conversation

cdmatters
Copy link
Contributor

@cdmatters cdmatters commented Jun 23, 2021

Indicators are (yn function, getline or xwaitforspace). Add this observation to NetHackChallenge.

This observation is an array of ints that can later be expanded to more
data if necessary, although the current entries are booleans (0 or 1).

Tests inbound. Tests shipped.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2021
Copy link
Contributor

@heiner heiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo lint check, LGTM.

(Btw pre-submit install should give you such a check at pre-commit time.)

getline or waitforspace). Add this observation to NetHackChallenge.

This observation is an array of ints that can later be expanded to more
data if necessary, although the current entries are booleans (0 or 1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants