Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

react-native-pytorch-core:externalNativeBuildDebug failed on android build above React-Native 66 #50

Closed
SomaKishimoto opened this issue Mar 15, 2022 · 2 comments
Closed

react-native-pytorch-core:externalNativeBuildDebug failed on android build above React-Native 66 #50

SomaKishimoto opened this issue Mar 15, 2022 · 2 comments
Assignees
@liuyinglao
Labels
🤖 android Issue related to Android 🐛 bug Something isn't working

Comments

@SomaKishimoto
Copy link

Version

0.1.3

Problem Area

react-native-pytorch-core (core package)

Steps to Reproduce

  1. npx react-native init AwesomeTSProject --template react-native-template-typescript
    cd AwesomeTSProject
    yarn add react-native-pytorch-core

  2. follow tutorial

  3. cd android && ./gradlew assembleDebug

I attached the patch file for CMakeLists.txt, pls use that for android build above RN66.
BUT then, we can't build on android under RN65.
So, please make condition branch like this for the users

Expected Results

BUILD SUCCESSFUL

but

> Task :react-native-pytorch-core:externalNativeBuildDebug FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-pytorch-core:externalNativeBuildDebug'.
> Build command failed.

Code example, screenshot, or link to repository

there is same issue here, and already closed.

patch : react-native-pytorch-core+0.1.3.patch.zip
@SomaKishimoto SomaKishimoto changed the title react-native-pytorch-core:externalNativeBuildDebug failed on android build above React-Native 0.66 react-native-pytorch-core:externalNativeBuildDebug failed on android build above React-Native 66 Mar 15, 2022
@liuyinglao liuyinglao self-assigned this Mar 16, 2022
@raedle raedle added 🐛 bug Something isn't working 🤖 android Issue related to Android labels Mar 18, 2022
@raedle
Copy link
Contributor

raedle commented Mar 18, 2022

Thanks for the report and for providing the patch, @SomaKishimoto!

We are considering it for a forward fix

facebook-github-bot pushed a commit that referenced this issue Mar 22, 2022
@liuyinglao @facebook-github-bot
support app with RN 0.66+
7b0a7cd 
Summary:
#50

For app with RN 0.66+, jsi need to be included as library (instead of build locally)

Reviewed By: chrisklaiber, raedle

Differential Revision: D34980156

fbshipit-source-id: b529fc0f3af8a5638e4d19a40e4c7992fb99685d
@liuyinglao
Copy link
Contributor

@SomaKishimoto we have pushed a fix for the RN 0.64+ and please let us know if you have other questions/comments!

@Gernii Gernii mentioned this issue May 21, 2022
Closed
@SomaKishimoto SomaKishimoto mentioned this issue Jun 16, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@liuyinglao liuyinglao

Labels
🤖 android Issue related to Android 🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raedle @liuyinglao @SomaKishimoto